2017-03-02 20:26:29 +05:30
|
|
|
require_relative "./extend/formula_cop"
|
|
|
|
|
2017-01-18 15:54:47 +05:30
|
|
|
module RuboCop
|
|
|
|
module Cop
|
2017-02-12 11:07:03 +05:30
|
|
|
module Homebrew
|
2017-03-02 20:26:29 +05:30
|
|
|
# This cop audits `bottle` block in Formulae
|
|
|
|
#
|
|
|
|
# - `rebuild` should be used instead of `revision` in `bottle` block
|
2017-01-18 15:54:47 +05:30
|
|
|
|
2017-03-02 20:26:29 +05:30
|
|
|
class CorrectBottleBlock < FormulaCop
|
|
|
|
MSG = "Use rebuild instead of revision in bottle block".freeze
|
2017-01-18 15:54:47 +05:30
|
|
|
|
2017-03-02 20:26:29 +05:30
|
|
|
def audit_formula(_node, _class_node, _parent_class_node, formula_class_body_node)
|
|
|
|
check(formula_class_body_node)
|
2017-01-18 15:54:47 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
private
|
|
|
|
|
2017-03-02 20:26:29 +05:30
|
|
|
def check(formula_class_body_node)
|
|
|
|
formula_class_body_node.each_child_node(:block) do |block_node|
|
|
|
|
next if block_length(block_node).zero?
|
|
|
|
method, _args, block_body = *block_node
|
|
|
|
_keyword, method_name = *method
|
|
|
|
next unless method_name == :bottle
|
|
|
|
check_revision?(block_body)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-01-18 15:54:47 +05:30
|
|
|
def autocorrect(node)
|
2017-01-18 15:55:32 +05:30
|
|
|
lambda do |corrector|
|
2017-01-18 22:37:11 +05:30
|
|
|
correction = node.source.sub("revision", "rebuild")
|
|
|
|
corrector.insert_before(node.source_range, correction)
|
|
|
|
corrector.remove(node.source_range)
|
2017-01-18 15:54:47 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-01-18 22:37:11 +05:30
|
|
|
def check_revision?(body)
|
2017-01-18 15:54:47 +05:30
|
|
|
body.children.each do |method_call_node|
|
2017-01-18 15:55:32 +05:30
|
|
|
_receiver, method_name, _args = *method_call_node
|
2017-01-18 22:37:11 +05:30
|
|
|
next unless method_name == :revision
|
|
|
|
add_offense(method_call_node, :expression)
|
2017-01-18 15:54:47 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|