admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
brew/Dockerfile

80 lines
2.8 KiB
Docker
Raw Normal View History

workflows/docker: base homebrew/brew on 22.04 Also disable fail-fast so that if a image upload fails we don't stop the other uploads halfway.
2022-04-28 21:21:38 +01:00
ARG version=22.04
Dockerfile: cleanup style, add comments.
2022-12-13 10:40:41 +00:00
# version is passed through by Docker.
style: brew style check Dockerfile as shell script
2021-09-14 21:23:39 +08:00
# shellcheck disable=SC2154
FROM ubuntu:"${version}"
Build Docker images for Ubuntu 18.04 and 20.04
2020-04-27 22:37:35 -07:00
ARG DEBIAN_FRONTEND=noninteractive
Add Dockerfile
2018-10-23 21:37:15 -07:00
Dockerfile: cleanup style, add comments.
2022-12-13 10:40:41 +00:00
# We don't want to manually pin versions, happy to use whatever
# Ubuntu thinks is best.
Lint the homebrew/brew Dockerfile with `hadolint` - I suggested this for the contents of [Linuxbrew/docker](https://github.com/Linuxbrew/docker) in https://github.com/Linuxbrew/docker/issues/75. People agreed, and Shaun asked me to do the same here. - This adds a step to CI to lint the Dockerfile, via [hadolint](https://github.com/hadolint/hadolint), on Ubuntu. - The linting errors it surfaced on this Dockerfile were: ``` Dockerfile:4 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>` Dockerfile:30 DL3020 Use COPY instead of ADD for files and folders Dockerfile:32 DL3003 Use WORKDIR to switch to a directory ``` - [DL3008](https://github.com/hadolint/hadolint/wiki/DL3008) - pinning versions in `apt-get install` - is at odds with what we recommend in the normal Homebrew on Linux dependency install instructions. We don't want the dependency management of having to check each of these Dockerfiles periodically for the latest version numbers of packages and have to update them. So I've disabled this lint. - [DL3003](https://github.com/hadolint/hadolint/wiki/DL3003) - use WORKDIR to `cd` - is disabled in this case due to [review comments](https://github.com/Homebrew/brew/pull/7433/files#r415098255).
2020-04-25 14:16:34 +01:00
# hadolint ignore=DL3008
Dockerfile: cleanup style, add comments.
2022-12-13 10:40:41 +00:00
# /etc/lsb-release is checked inside the container and sets DISTRIB_RELEASE.
Fix `brew style`
2023-03-16 01:19:54 +08:00
# We need `[` instead of `[[` because the shell is `/bin/sh`.
# shellcheck disable=SC1091,SC2154,SC2292
Add Dockerfile
2018-10-23 21:37:15 -07:00
RUN apt-get update \
Dockerfile: it's gnupg not gpg on 16.04
2022-04-25 07:59:51 +02:00
&& apt-get install -y --no-install-recommends software-properties-common gnupg-agent \
Dockerfile: restore git-core PPA
2020-05-03 14:29:09 +01:00
&& add-apt-repository -y ppa:git-core/ppa \
&& apt-get update \
Dockerfile: Tabs to spaces - My editor converted some of these to spaces when I changed the lines in the previous commit. We should be consistent, so I made all of them into spaces.
2020-04-26 09:55:14 +01:00
&& apt-get install -y --no-install-recommends \
Dockerfile: cleanup style, add comments.
2022-12-13 10:40:41 +00:00
acl \
bzip2 \
ca-certificates \
curl \
file \
fonts-dejavu-core \
g++ \
gawk \
git \
docker: stop building Ubuntu 16.04 image. This is too slow to be building every time and we're long past the deprecation date. Fixes https://github.com/Homebrew/brew/issues/14661
2023-03-24 08:57:48 +00:00
gpg \
Dockerfile: cleanup style, add comments.
2022-12-13 10:40:41 +00:00
less \
libz-dev \
locales \
make \
netbase \
openssh-client \
patch \
sudo \
Dockerfile: `apt-get install` more useful things We need all of these in various homebrew/core workflows.
2023-03-14 06:53:02 -04:00
unzip \
Dockerfile: cleanup style, add comments.
2022-12-13 10:40:41 +00:00
uuid-runtime \
tzdata \
jq \
Dockerfile: install gh from Homebrew apt installs an ancient `gh` that is missing some important flags. In particular, we probably do want the `--match-head-commit` flag for the extra security it gives us.
2023-04-21 17:32:42 +08:00
&& if [ "$(. /etc/lsb-release; echo "${DISTRIB_RELEASE}" | cut -d. -f1)" -ge 22 ]; then apt-get install -y --no-install-recommends skopeo; fi \
Install `gh` from GitHub Debian repository
2023-04-21 18:01:08 +08:00
&& curl -fsSL https://cli.github.com/packages/githubcli-archive-keyring.gpg | dd of=/usr/share/keyrings/githubcli-archive-keyring.gpg \
&& chmod go+r /usr/share/keyrings/githubcli-archive-keyring.gpg \
&& echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/githubcli-archive-keyring.gpg] https://cli.github.com/packages stable main" | tee /etc/apt/sources.list.d/github-cli.list > /dev/null \
&& apt-get update \
&& apt-get install -y --no-install-recommends gh \
Dockerfile: install gpg
2022-11-30 16:02:46 +00:00
&& apt-get remove --purge -y software-properties-common \
&& apt-get autoremove --purge -y \
Build Docker images for Ubuntu 18.04 and 20.04
2020-04-27 22:37:35 -07:00
&& rm -rf /var/lib/apt/lists/* \
Dockerfile: set default `umask` This makes sure that the system `umask` is the same as the one on macOS. Fixes Homebrew/homebrew-core@155e3ab5a88fb373342db5af0bc42499c5124402.
2023-06-01 13:58:33 +08:00
&& sed -i -E '/^session optional\s+pam_umask\.so$/ s/$/ umask=0022/' /etc/pam.d/common-session \
Build Docker images for Ubuntu 18.04 and 20.04
2020-04-27 22:37:35 -07:00
&& localedef -i en_US -f UTF-8 en_US.UTF-8 \
Dockerfile: Tabs to spaces - My editor converted some of these to spaces when I changed the lines in the previous commit. We should be consistent, so I made all of them into spaces.
2020-04-26 09:55:14 +01:00
&& useradd -m -s /bin/bash linuxbrew \
Dockerfile: run as user: linuxbrew This commit refactors the Dockerfile in order to resolve build errors caused by attempting to execute `brew` commands as the root user. We need to create the `/home/linuxbrew/.linuxbrew` folder prior to copying the local directory into `/home/linuxbrew/.linuxbrew/Homebrew` (and ensure the appropriate user owns it), as failing to do so will create `/home/linuxbrew/.linuxbrew` with root user and group ownership, causing the subsequent `mkdir` command called in the second `RUN` instruction to fail. closes #11802
2021-08-03 17:56:21 -06:00
&& echo 'linuxbrew ALL=(ALL) NOPASSWD:ALL' >>/etc/sudoers \
&& su - linuxbrew -c 'mkdir ~/.linuxbrew'
Build Docker images for Ubuntu 18.04 and 20.04
2020-04-27 22:37:35 -07:00
Dockerfile: run as user: linuxbrew This commit refactors the Dockerfile in order to resolve build errors caused by attempting to execute `brew` commands as the root user. We need to create the `/home/linuxbrew/.linuxbrew` folder prior to copying the local directory into `/home/linuxbrew/.linuxbrew/Homebrew` (and ensure the appropriate user owns it), as failing to do so will create `/home/linuxbrew/.linuxbrew` with root user and group ownership, causing the subsequent `mkdir` command called in the second `RUN` instruction to fail. closes #11802
2021-08-03 17:56:21 -06:00
USER linuxbrew
COPY --chown=linuxbrew:linuxbrew . /home/linuxbrew/.linuxbrew/Homebrew
style: fix inconsistent code style for shell scripts
2021-09-13 20:32:20 +08:00
ENV PATH="/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin:${PATH}"
Build Docker images for Ubuntu 18.04 and 20.04
2020-04-27 22:37:35 -07:00
WORKDIR /home/linuxbrew
Lint the homebrew/brew Dockerfile with `hadolint` - I suggested this for the contents of [Linuxbrew/docker](https://github.com/Linuxbrew/docker) in https://github.com/Linuxbrew/docker/issues/75. People agreed, and Shaun asked me to do the same here. - This adds a step to CI to lint the Dockerfile, via [hadolint](https://github.com/hadolint/hadolint), on Ubuntu. - The linting errors it surfaced on this Dockerfile were: ``` Dockerfile:4 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>` Dockerfile:30 DL3020 Use COPY instead of ADD for files and folders Dockerfile:32 DL3003 Use WORKDIR to switch to a directory ``` - [DL3008](https://github.com/hadolint/hadolint/wiki/DL3008) - pinning versions in `apt-get install` - is at odds with what we recommend in the normal Homebrew on Linux dependency install instructions. We don't want the dependency management of having to check each of these Dockerfiles periodically for the latest version numbers of packages and have to update them. So I've disabled this lint. - [DL3003](https://github.com/hadolint/hadolint/wiki/DL3003) - use WORKDIR to `cd` - is disabled in this case due to [review comments](https://github.com/Homebrew/brew/pull/7433/files#r415098255).
2020-04-25 14:16:34 +01:00
Revert "Revert "Dockerfile: use relative paths when in the /home/linuxbrew directory"" This reverts commit 6d61fb03cd0da78b41dc0d66663a6e3abf224276.
2021-08-18 16:55:05 +02:00
RUN mkdir -p \
Dockerfile: cleanup style, add comments.
2022-12-13 10:40:41 +00:00
.linuxbrew/bin \
.linuxbrew/etc \
.linuxbrew/include \
.linuxbrew/lib \
.linuxbrew/opt \
.linuxbrew/sbin \
.linuxbrew/share \
.linuxbrew/var/homebrew/linked \
.linuxbrew/Cellar \
Revert "Revert "Dockerfile: use relative paths when in the /home/linuxbrew directory"" This reverts commit 6d61fb03cd0da78b41dc0d66663a6e3abf224276.
2021-08-18 16:55:05 +02:00
&& ln -s ../Homebrew/bin/brew .linuxbrew/bin/brew \
&& git -C .linuxbrew/Homebrew remote set-url origin https://github.com/Homebrew/brew \
&& git -C .linuxbrew/Homebrew fetch origin \
Build Docker images for Ubuntu 18.04 and 20.04
2020-04-27 22:37:35 -07:00
&& HOMEBREW_NO_ANALYTICS=1 HOMEBREW_NO_AUTO_UPDATE=1 brew tap homebrew/core \
Dockerfile: Tabs to spaces - My editor converted some of these to spaces when I changed the lines in the previous commit. We should be consistent, so I made all of them into spaces.
2020-04-26 09:55:14 +01:00
&& brew install-bundler-gems \
Build Docker images for Ubuntu 18.04 and 20.04
2020-04-27 22:37:35 -07:00
&& brew cleanup \
Revert "Revert "Dockerfile: use relative paths when in the /home/linuxbrew directory"" This reverts commit 6d61fb03cd0da78b41dc0d66663a6e3abf224276.
2021-08-18 16:55:05 +02:00
&& { git -C .linuxbrew/Homebrew config --unset gc.auto; true; } \
&& { git -C .linuxbrew/Homebrew config --unset homebrew.devcmdrun; true; } \
&& rm -rf .cache
Reference in New Issue Copy Permalink