2024-02-06 22:12:51 +01:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2024-02-18 15:11:11 -08:00
|
|
|
RSpec.describe Cask::CaskLoader, :cask do
|
2024-02-06 22:12:51 +01:00
|
|
|
describe "::for" do
|
|
|
|
let(:tap) { CoreCaskTap.instance }
|
|
|
|
|
|
|
|
context "when a cask is renamed" do
|
|
|
|
let(:old_token) { "version-newest" }
|
|
|
|
let(:new_token) { "version-latest" }
|
|
|
|
|
|
|
|
let(:api_casks) do
|
|
|
|
[old_token, new_token].to_h do |token|
|
|
|
|
hash = described_class.load(new_token).to_hash_with_variations
|
|
|
|
json = JSON.pretty_generate(hash)
|
|
|
|
cask_json = JSON.parse(json)
|
|
|
|
|
|
|
|
[token, cask_json.except("token")]
|
|
|
|
end
|
|
|
|
end
|
|
|
|
let(:cask_renames) do
|
|
|
|
{ old_token => new_token }
|
|
|
|
end
|
|
|
|
|
|
|
|
before do
|
|
|
|
allow(Homebrew::API::Cask)
|
|
|
|
.to receive(:all_casks)
|
|
|
|
.and_return(api_casks)
|
|
|
|
|
|
|
|
allow(tap).to receive(:cask_renames)
|
|
|
|
.and_return(cask_renames)
|
|
|
|
end
|
|
|
|
|
2024-03-19 22:18:02 -07:00
|
|
|
context "when not using the API", :no_api do
|
2024-02-06 22:12:51 +01:00
|
|
|
it "warns when using the short token" do
|
|
|
|
expect do
|
2024-02-08 14:53:55 +01:00
|
|
|
expect(described_class.for("version-newest")).to be_a Cask::CaskLoader::FromPathLoader
|
2024-02-06 22:12:51 +01:00
|
|
|
end.to output(/version-newest was renamed to version-latest/).to_stderr
|
|
|
|
end
|
|
|
|
|
|
|
|
it "warns when using the full token" do
|
|
|
|
expect do
|
2024-02-08 14:53:55 +01:00
|
|
|
expect(described_class.for("homebrew/cask/version-newest")).to be_a Cask::CaskLoader::FromPathLoader
|
2024-02-06 22:12:51 +01:00
|
|
|
end.to output(/version-newest was renamed to version-latest/).to_stderr
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when using the API" do
|
|
|
|
before do
|
|
|
|
ENV.delete("HOMEBREW_NO_INSTALL_FROM_API")
|
|
|
|
end
|
|
|
|
|
|
|
|
it "warns when using the short token" do
|
|
|
|
expect do
|
|
|
|
expect(described_class.for("version-newest")).to be_a Cask::CaskLoader::FromAPILoader
|
|
|
|
end.to output(/version-newest was renamed to version-latest/).to_stderr
|
|
|
|
end
|
|
|
|
|
|
|
|
it "warns when using the full token" do
|
|
|
|
expect do
|
|
|
|
expect(described_class.for("homebrew/cask/version-newest")).to be_a Cask::CaskLoader::FromAPILoader
|
|
|
|
end.to output(/version-newest was renamed to version-latest/).to_stderr
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2024-02-13 21:12:51 +01:00
|
|
|
|
2024-03-19 22:18:02 -07:00
|
|
|
context "when not using the API", :no_api do
|
2024-03-06 23:06:36 +01:00
|
|
|
context "when a cask is migrated" do
|
2024-02-13 21:12:51 +01:00
|
|
|
let(:token) { "local-caffeine" }
|
2024-03-06 23:06:36 +01:00
|
|
|
|
|
|
|
let(:core_tap) { CoreTap.instance }
|
|
|
|
let(:core_cask_tap) { CoreCaskTap.instance }
|
|
|
|
|
2024-02-13 21:12:51 +01:00
|
|
|
let(:tap_migrations) do
|
|
|
|
{
|
2024-03-06 23:06:36 +01:00
|
|
|
token => new_tap.name,
|
2024-02-13 21:12:51 +01:00
|
|
|
}
|
|
|
|
end
|
|
|
|
|
|
|
|
before do
|
2024-03-06 23:06:36 +01:00
|
|
|
old_tap.path.mkpath
|
|
|
|
new_tap.path.mkpath
|
2024-02-13 21:12:51 +01:00
|
|
|
(old_tap.path/"tap_migrations.json").write tap_migrations.to_json
|
|
|
|
end
|
|
|
|
|
2024-03-06 23:06:36 +01:00
|
|
|
context "to a formula in the default tap" do
|
|
|
|
let(:old_tap) { core_cask_tap }
|
|
|
|
let(:new_tap) { core_tap }
|
2024-02-13 21:12:51 +01:00
|
|
|
|
2024-03-06 23:06:36 +01:00
|
|
|
let(:formula_file) { new_tap.formula_dir/"#{token}.rb" }
|
2024-02-13 21:12:51 +01:00
|
|
|
|
2024-03-06 23:06:36 +01:00
|
|
|
before do
|
|
|
|
new_tap.formula_dir.mkpath
|
|
|
|
FileUtils.touch formula_file
|
|
|
|
end
|
|
|
|
|
|
|
|
it "warn only once" do
|
|
|
|
expect do
|
|
|
|
described_class.for(token)
|
|
|
|
end.to output(
|
|
|
|
a_string_including("Warning: Cask #{token} was renamed to #{new_tap}/#{token}.").once,
|
|
|
|
).to_stderr
|
|
|
|
end
|
2024-02-13 21:12:51 +01:00
|
|
|
end
|
2024-02-16 10:22:10 +01:00
|
|
|
|
2024-03-06 23:06:36 +01:00
|
|
|
context "to the default tap" do
|
|
|
|
let(:old_tap) { core_tap }
|
|
|
|
let(:new_tap) { core_cask_tap }
|
|
|
|
|
|
|
|
let(:cask_file) { new_tap.cask_dir/"#{token}.rb" }
|
|
|
|
|
|
|
|
before do
|
|
|
|
new_tap.cask_dir.mkpath
|
|
|
|
FileUtils.touch cask_file
|
|
|
|
end
|
|
|
|
|
|
|
|
it "does not warn when loading the short token" do
|
|
|
|
expect do
|
|
|
|
described_class.for(token)
|
|
|
|
end.not_to output.to_stderr
|
|
|
|
end
|
|
|
|
|
|
|
|
it "does not warn when loading the full token in the default tap" do
|
|
|
|
expect do
|
|
|
|
described_class.for("#{new_tap}/#{token}")
|
|
|
|
end.not_to output.to_stderr
|
|
|
|
end
|
|
|
|
|
|
|
|
it "warns when loading the full token in the old tap" do
|
|
|
|
expect do
|
|
|
|
described_class.for("#{old_tap}/#{token}")
|
|
|
|
end.to output(%r{Cask #{old_tap}/#{token} was renamed to #{token}\.}).to_stderr
|
|
|
|
end
|
|
|
|
|
|
|
|
# FIXME
|
|
|
|
# context "when there is an infinite tap migration loop" do
|
|
|
|
# before do
|
|
|
|
# (new_tap.path/"tap_migrations.json").write({
|
|
|
|
# token => old_tap.name,
|
|
|
|
# }.to_json)
|
|
|
|
# end
|
|
|
|
#
|
|
|
|
# it "stops recursing" do
|
|
|
|
# expect do
|
|
|
|
# described_class.for("#{new_tap}/#{token}")
|
|
|
|
# end.not_to output.to_stderr
|
|
|
|
# end
|
|
|
|
# end
|
|
|
|
end
|
2024-02-13 21:12:51 +01:00
|
|
|
end
|
|
|
|
end
|
2024-02-06 22:12:51 +01:00
|
|
|
end
|
|
|
|
end
|