brew/Library/Homebrew/extend/os/mac/simulate_system.rb

# typed: true # rubocop:disable Sorbet/StrictSigil
# frozen_string_literal: true

module Homebrew
  class SimulateSystem
    class << self
      undef simulating_or_running_on_macos?
      undef current_os

      sig { returns(T::Boolean) }
      def simulating_or_running_on_macos?
        os.blank? || [:macos, *MacOSVersion::SYMBOLS.keys].include?(os)
      end

      sig { returns(Symbol) }
      def current_os
        os || MacOS.version.to_sym
      end
    end
  end
end
rubocop: Use `Sorbet/StrictSigil` as it's better than comments - Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' \| wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ``` 2024-08-12 10:30:59 +01:00			`# typed: true # rubocop:disable Sorbet/StrictSigil`
Move SimulateSystem check to extend/os 2022-11-21 21:04:22 -08:00			`# frozen_string_literal: true`

			`module Homebrew`
			`class SimulateSystem`
			`class << self`
			`undef simulating_or_running_on_macos?`
			`undef current_os`

			`sig { returns(T::Boolean) }`
			`def simulating_or_running_on_macos?`
Rename `OS::Mac::Version` to `MacOSVersion`. 2023-05-09 02:15:28 +02:00			`os.blank? \|\| [:macos, *MacOSVersion::SYMBOLS.keys].include?(os)`
Move SimulateSystem check to extend/os 2022-11-21 21:04:22 -08:00			`end`

			`sig { returns(Symbol) }`
			`def current_os`
			`os \|\| MacOS.version.to_sym`
			`end`
			`end`
			`end`
			`end`