2019-01-21 13:39:11 +00:00
|
|
|
inherit_from: ../.rubocop_rspec.yml
|
2016-09-27 18:48:06 +02:00
|
|
|
|
|
|
|
|
AllCops:
|
|
|
|
|
Include:
|
2018-06-06 23:05:00 -04:00
|
|
|
- '**/*.rb'
|
2018-06-11 15:56:56 -04:00
|
|
|
- 'Library/Homebrew/.simplecov'
|
2016-09-27 18:48:06 +02:00
|
|
|
Exclude:
|
2018-01-07 15:40:42 +00:00
|
|
|
- 'bin/*'
|
2016-09-28 22:34:09 +02:00
|
|
|
- '**/vendor/**/*'
|
2016-09-27 18:48:06 +02:00
|
|
|
|
2019-04-30 09:19:29 +01:00
|
|
|
# messes up system formatting for formulae but good for Homebrew/brew
|
2019-11-28 15:10:50 +00:00
|
|
|
Layout/ArgumentAlignment:
|
2019-04-30 09:19:29 +01:00
|
|
|
Enabled: true
|
|
|
|
|
|
2018-09-02 20:14:54 +01:00
|
|
|
# make rspec formatting more flexible
|
2017-05-28 16:59:53 +01:00
|
|
|
Layout/MultilineMethodCallIndentation:
|
2016-10-23 14:44:14 +02:00
|
|
|
Exclude:
|
2017-02-12 17:26:34 +01:00
|
|
|
- '**/*_spec.rb'
|
2016-10-23 14:44:14 +02:00
|
|
|
|
2016-10-22 13:32:46 +01:00
|
|
|
# so many of these in formulae but none in here
|
|
|
|
|
Lint/AmbiguousRegexpLiteral:
|
|
|
|
|
Enabled: true
|
|
|
|
|
|
2020-03-13 21:14:24 +00:00
|
|
|
# TODO: add parentheses for these and remove
|
|
|
|
|
Lint/AssignmentInCondition:
|
|
|
|
|
Enabled: false
|
|
|
|
|
|
2016-09-27 18:48:06 +02:00
|
|
|
# `formula do` uses nested method definitions
|
|
|
|
|
Lint/NestedMethodDefinition:
|
|
|
|
|
Exclude:
|
2016-09-28 22:34:09 +02:00
|
|
|
- 'test/**/*'
|
2016-09-27 18:48:06 +02:00
|
|
|
|
2016-10-22 13:32:46 +01:00
|
|
|
# so many of these in formulae but none in here
|
|
|
|
|
Lint/ParenthesesAsGroupedExpression:
|
2016-10-22 15:53:18 +01:00
|
|
|
Enabled: true
|
2016-10-22 13:32:46 +01:00
|
|
|
|
2017-10-27 09:34:38 +01:00
|
|
|
# TODO: try to bring down all metrics maximums
|
|
|
|
|
Metrics/AbcSize:
|
2018-09-02 20:14:54 +01:00
|
|
|
Enabled: true
|
|
|
|
|
Max: 275
|
2017-10-09 18:27:02 +02:00
|
|
|
Metrics/BlockLength:
|
2018-09-02 20:14:54 +01:00
|
|
|
Enabled: true
|
|
|
|
|
Max: 1100
|
2020-03-16 01:37:49 +05:30
|
|
|
Exclude:
|
|
|
|
|
- 'test/formula_spec.rb'
|
2017-10-07 00:31:28 +02:00
|
|
|
Metrics/BlockNesting:
|
2018-09-02 20:14:54 +01:00
|
|
|
Enabled: true
|
2017-10-07 00:31:28 +02:00
|
|
|
Max: 5
|
2017-10-09 18:27:02 +02:00
|
|
|
Metrics/ClassLength:
|
2018-09-02 20:14:54 +01:00
|
|
|
Enabled: true
|
|
|
|
|
Max: 1400
|
2017-10-27 09:34:38 +01:00
|
|
|
Metrics/CyclomaticComplexity:
|
2018-09-02 20:14:54 +01:00
|
|
|
Enabled: true
|
2020-06-22 14:09:33 +01:00
|
|
|
Max: 85
|
2017-10-09 18:27:02 +02:00
|
|
|
Metrics/MethodLength:
|
2018-09-02 20:14:54 +01:00
|
|
|
Enabled: true
|
|
|
|
|
Max: 300
|
2017-10-27 09:34:38 +01:00
|
|
|
Metrics/ModuleLength:
|
2018-09-02 20:14:54 +01:00
|
|
|
Enabled: true
|
2019-07-02 14:50:02 +02:00
|
|
|
Max: 550
|
2017-10-27 09:34:38 +01:00
|
|
|
Metrics/PerceivedComplexity:
|
2018-09-02 20:14:54 +01:00
|
|
|
Enabled: true
|
2017-10-27 09:34:38 +01:00
|
|
|
Max: 100
|
|
|
|
|
|
2017-10-07 00:31:28 +02:00
|
|
|
# we won't change backward compatible predicate names
|
|
|
|
|
Naming/PredicateName:
|
|
|
|
|
Exclude:
|
|
|
|
|
- 'compat/**/*'
|
2019-01-23 21:57:37 +00:00
|
|
|
# can't rename these
|
2019-11-28 15:10:50 +00:00
|
|
|
AllowedMethods: is_32_bit?, is_64_bit?
|
2017-10-07 00:31:28 +02:00
|
|
|
|
2020-06-06 19:12:12 +01:00
|
|
|
# allow those that are standard
|
2018-09-02 20:14:54 +01:00
|
|
|
# TODO: try to remove some of these
|
2019-11-28 15:10:50 +00:00
|
|
|
Naming/MethodParameterName:
|
2018-09-02 20:14:54 +01:00
|
|
|
AllowedNames:
|
|
|
|
|
- '_'
|
|
|
|
|
- 'a'
|
|
|
|
|
- 'b'
|
|
|
|
|
- 'cc'
|
|
|
|
|
- 'c1'
|
|
|
|
|
- 'c2'
|
|
|
|
|
- 'd'
|
|
|
|
|
- 'e'
|
|
|
|
|
- 'f'
|
|
|
|
|
- 'ff'
|
|
|
|
|
- 'fn'
|
|
|
|
|
- 'id'
|
|
|
|
|
- 'io'
|
|
|
|
|
- 'o'
|
|
|
|
|
- 'p'
|
|
|
|
|
- 'pr'
|
|
|
|
|
- 'r'
|
|
|
|
|
- 'rb'
|
|
|
|
|
- 's'
|
|
|
|
|
- 'to'
|
|
|
|
|
- 'v'
|
2018-03-05 11:46:38 +00:00
|
|
|
|
2018-06-06 23:34:19 -04:00
|
|
|
# Avoid false positives on modifiers used on symbols of methods
|
|
|
|
|
# See https://github.com/rubocop-hq/rubocop/issues/5953
|
2018-06-06 23:05:00 -04:00
|
|
|
Style/AccessModifierDeclarations:
|
|
|
|
|
Enabled: false
|
|
|
|
|
|
2018-09-02 20:14:54 +01:00
|
|
|
# make rspec formatting more flexible
|
2017-05-28 16:59:53 +01:00
|
|
|
Style/BlockDelimiters:
|
|
|
|
|
Exclude:
|
|
|
|
|
- '**/*_spec.rb'
|
2017-10-03 10:49:58 +02:00
|
|
|
- '**/shared_examples/**/*.rb'
|
2017-05-28 16:59:53 +01:00
|
|
|
|
2020-07-07 11:29:33 +01:00
|
|
|
# don't group nicely documented or private attr_readers
|
|
|
|
|
Style/AccessorGrouping:
|
|
|
|
|
Exclude:
|
|
|
|
|
- 'formula.rb'
|
|
|
|
|
- 'formulary.rb'
|
|
|
|
|
- 'migrator.rb'
|
|
|
|
|
- 'resource.rb'
|
|
|
|
|
- 'system_command.rb'
|
|
|
|
|
- 'tap.rb'
|
|
|
|
|
|
2018-09-02 20:14:54 +01:00
|
|
|
# document our public APIs
|
|
|
|
|
Style/Documentation:
|
|
|
|
|
Enabled: true
|
|
|
|
|
Include:
|
2020-07-07 11:29:33 +01:00
|
|
|
- 'formula.rb'
|
2018-09-02 20:14:54 +01:00
|
|
|
Style/DocumentationMethod:
|
|
|
|
|
Enabled: true
|
|
|
|
|
Include:
|
2020-07-07 11:29:33 +01:00
|
|
|
- 'formula.rb'
|
2018-09-02 20:14:54 +01:00
|
|
|
|
2019-04-19 15:21:16 +09:00
|
|
|
# don't want this for formulae but re-enabled for Library/Homebrew
|
|
|
|
|
Style/FrozenStringLiteralComment:
|
|
|
|
|
Enabled: true
|
|
|
|
|
EnforcedStyle: always
|
2020-07-27 12:57:29 +01:00
|
|
|
Exclude:
|
|
|
|
|
- '**/Casks/**/*.rb'
|
2019-04-19 15:21:16 +09:00
|
|
|
|
2016-10-22 13:32:46 +01:00
|
|
|
# so many of these in formulae but none in here
|
|
|
|
|
Style/GuardClause:
|
|
|
|
|
Enabled: true
|