| 
									
										
										
										
											2021-01-31 14:50:29 -05:00
										 |  |  | # frozen_string_literal: true | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | require "rubocops/lines" | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2024-02-18 15:11:11 -08:00
										 |  |  | RSpec.describe RuboCop::Cop::FormulaAuditStrict::MakeCheck do | 
					
						
							| 
									
										
										
										
											2021-01-31 14:50:29 -05:00
										 |  |  |   subject(:cop) { described_class.new } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2024-08-10 13:35:20 -07:00
										 |  |  |   let(:path) { HOMEBREW_TAP_DIRECTORY/"homebrew/homebrew-core" } | 
					
						
							| 
									
										
										
										
											2021-01-31 14:50:29 -05:00
										 |  |  | 
 | 
					
						
							|  |  |  |   before do | 
					
						
							|  |  |  |     path.mkpath | 
					
						
							|  |  |  |     (path/"style_exceptions").mkpath | 
					
						
							|  |  |  |   end | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |   def setup_style_exceptions | 
					
						
							|  |  |  |     (path/"style_exceptions/make_check_allowlist.json").write <<~JSON | 
					
						
							|  |  |  |       [ "bar" ] | 
					
						
							|  |  |  |     JSON | 
					
						
							|  |  |  |   end | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |   it "reports an offense when formulae in homebrew/core run build-time checks" do | 
					
						
							|  |  |  |     setup_style_exceptions | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     expect_offense(<<~RUBY, "#{path}/Formula/foo.rb") | 
					
						
							|  |  |  |       class Foo < Formula | 
					
						
							|  |  |  |         desc "foo" | 
					
						
							|  |  |  |         url 'https://brew.sh/foo-1.0.tgz' | 
					
						
							|  |  |  |         system "make", "-j1", "test" | 
					
						
							| 
									
										
										
										
											2023-04-07 17:16:48 +01:00
										 |  |  |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ FormulaAuditStrict/MakeCheck: Formulae in homebrew/core (except e.g. cryptography, libraries) should not run build-time checks | 
					
						
							| 
									
										
										
										
											2021-01-31 14:50:29 -05:00
										 |  |  |       end | 
					
						
							|  |  |  |     RUBY | 
					
						
							|  |  |  |   end | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |   it "reports no offenses when exempted formulae in homebrew/core run build-time checks" do | 
					
						
							|  |  |  |     setup_style_exceptions | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     expect_no_offenses(<<~RUBY, "#{path}/Formula/bar.rb") | 
					
						
							|  |  |  |       class Bar < Formula | 
					
						
							|  |  |  |         desc "bar" | 
					
						
							|  |  |  |         url 'https://brew.sh/bar-1.0.tgz' | 
					
						
							|  |  |  |         system "make", "-j1", "test" | 
					
						
							|  |  |  |       end | 
					
						
							|  |  |  |     RUBY | 
					
						
							|  |  |  |   end | 
					
						
							|  |  |  | end |