2020-12-24 03:33:14 +01:00
|
|
|
# typed: true
|
2020-08-08 07:16:06 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
module Homebrew
|
|
|
|
module Livecheck
|
|
|
|
module Strategy
|
2020-11-05 17:17:03 -05:00
|
|
|
# The {PageMatch} strategy fetches content at a URL and scans it for
|
2020-08-08 07:16:06 +05:30
|
|
|
# matching text using the provided regex.
|
|
|
|
#
|
|
|
|
# This strategy can be used in a `livecheck` block when no specific
|
2020-11-05 17:17:03 -05:00
|
|
|
# strategies apply to a given URL. Though {PageMatch} will technically
|
2020-08-08 07:16:06 +05:30
|
|
|
# match any HTTP URL, the strategy also requires a regex to function.
|
|
|
|
#
|
2023-02-23 13:41:56 -05:00
|
|
|
# The {find_versions} method can be used within other strategies, to
|
|
|
|
# handle the process of identifying version text in content.
|
2020-08-08 07:16:06 +05:30
|
|
|
#
|
|
|
|
# @api public
|
|
|
|
class PageMatch
|
2020-12-24 03:33:14 +01:00
|
|
|
extend T::Sig
|
|
|
|
|
2020-08-08 07:16:06 +05:30
|
|
|
NICE_NAME = "Page match"
|
|
|
|
|
|
|
|
# A priority of zero causes livecheck to skip the strategy. We do this
|
2021-08-10 18:38:21 -04:00
|
|
|
# for {PageMatch} so we can selectively apply it only when a regex is
|
|
|
|
# provided in a `livecheck` block.
|
2020-08-08 07:16:06 +05:30
|
|
|
PRIORITY = 0
|
|
|
|
|
|
|
|
# The `Regexp` used to determine if the strategy applies to the URL.
|
|
|
|
URL_MATCH_REGEX = %r{^https?://}i.freeze
|
|
|
|
|
|
|
|
# Whether the strategy can be applied to the provided URL.
|
2021-08-10 18:38:21 -04:00
|
|
|
# {PageMatch} will technically match any HTTP URL but is only
|
2020-12-12 21:56:07 +01:00
|
|
|
# usable with a `livecheck` block containing a regex.
|
2021-08-10 18:38:21 -04:00
|
|
|
#
|
|
|
|
# @param url [String] the URL to match against
|
|
|
|
# @return [Boolean]
|
2020-12-24 03:33:14 +01:00
|
|
|
sig { params(url: String).returns(T::Boolean) }
|
2020-08-08 07:16:06 +05:30
|
|
|
def self.match?(url)
|
|
|
|
URL_MATCH_REGEX.match?(url)
|
|
|
|
end
|
|
|
|
|
2020-12-22 22:46:52 -05:00
|
|
|
# Uses the regex to match text in the content or, if a block is
|
|
|
|
# provided, passes the page content to the block to handle matching.
|
|
|
|
# With either approach, an array of unique matches is returned.
|
2020-11-05 17:17:03 -05:00
|
|
|
#
|
2020-12-22 22:46:52 -05:00
|
|
|
# @param content [String] the page content to check
|
2021-08-19 10:20:11 -04:00
|
|
|
# @param regex [Regexp, nil] a regex used for matching versions in the
|
2020-08-08 07:16:06 +05:30
|
|
|
# content
|
|
|
|
# @return [Array]
|
2021-07-26 20:32:10 -04:00
|
|
|
sig {
|
|
|
|
params(
|
|
|
|
content: String,
|
2021-08-19 10:20:11 -04:00
|
|
|
regex: T.nilable(Regexp),
|
Handle variable strategy block arguments
There are times where a regex isn't needed in a `strategy` block and
these changes explicitly handle that situation.
This allows the Symbol Proc format used in some `Sparkle` `livecheck`
blocks (e.g., `strategy :sparkle, &:version`) to continue working
instead of failing with a "wrong number of arguments (given 1,
expected 0)" error. This error would occur because a Symbol Proc only
only expects one argument (e.g., an `Item`, not an `Item` and a
regex/nil).
There's an argument to be made for avoiding the Symbol Proc format
for `strategy` blocks but I haven't found a way of selectively
disabling the Style/SymbolProc cop only for a `strategy` DSL method
call. That is to say, if we don't use the Symbol Proc format, `brew
style` will give a "Pass &:version as an argument to strategy instead
of a block." offense.
Besides that, this also replaces the `block` type signatures in
livecheck strategies with `T.untyped`. Sorbet doesn't know how to
handle a `Proc` with a variable number of arguments and can't be
taught how (i.e., `T.any` with a `Proc` signature for each variation
doesn't work). The aforementioned changes cause Sorbet to complain
about there being both too many and too few arguments, so the only
way to win is not to play the game. Hopefully we can restore the
`block` type signatures in the future (if upstream resolves this
years-old issue) but `T.untyped` seems to be our only option for now.
2021-11-19 22:42:15 -05:00
|
|
|
block: T.untyped,
|
2021-07-26 20:32:10 -04:00
|
|
|
).returns(T::Array[String])
|
|
|
|
}
|
2021-08-10 11:09:55 -04:00
|
|
|
def self.versions_from_content(content, regex, &block)
|
Handle variable strategy block arguments
There are times where a regex isn't needed in a `strategy` block and
these changes explicitly handle that situation.
This allows the Symbol Proc format used in some `Sparkle` `livecheck`
blocks (e.g., `strategy :sparkle, &:version`) to continue working
instead of failing with a "wrong number of arguments (given 1,
expected 0)" error. This error would occur because a Symbol Proc only
only expects one argument (e.g., an `Item`, not an `Item` and a
regex/nil).
There's an argument to be made for avoiding the Symbol Proc format
for `strategy` blocks but I haven't found a way of selectively
disabling the Style/SymbolProc cop only for a `strategy` DSL method
call. That is to say, if we don't use the Symbol Proc format, `brew
style` will give a "Pass &:version as an argument to strategy instead
of a block." offense.
Besides that, this also replaces the `block` type signatures in
livecheck strategies with `T.untyped`. Sorbet doesn't know how to
handle a `Proc` with a variable number of arguments and can't be
taught how (i.e., `T.any` with a `Proc` signature for each variation
doesn't work). The aforementioned changes cause Sorbet to complain
about there being both too many and too few arguments, so the only
way to win is not to play the game. Hopefully we can restore the
`block` type signatures in the future (if upstream resolves this
years-old issue) but `T.untyped` seems to be our only option for now.
2021-11-19 22:42:15 -05:00
|
|
|
if block
|
|
|
|
block_return_value = regex.present? ? yield(content, regex) : yield(content)
|
|
|
|
return Strategy.handle_block_return(block_return_value)
|
|
|
|
end
|
|
|
|
|
2021-08-19 10:20:11 -04:00
|
|
|
return [] if regex.blank?
|
2020-12-14 02:07:07 +01:00
|
|
|
|
2020-12-22 22:46:52 -05:00
|
|
|
content.scan(regex).map do |match|
|
2020-12-15 20:08:53 +01:00
|
|
|
case match
|
|
|
|
when String
|
|
|
|
match
|
2021-07-26 20:32:10 -04:00
|
|
|
when Array
|
2020-12-15 20:08:53 +01:00
|
|
|
match.first
|
|
|
|
end
|
2021-07-26 20:32:10 -04:00
|
|
|
end.compact.uniq
|
2020-08-08 07:16:06 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
# Checks the content at the URL for new versions, using the provided
|
|
|
|
# regex for matching.
|
2020-12-23 09:12:53 -05:00
|
|
|
#
|
|
|
|
# @param url [String] the URL of the content to check
|
2021-08-19 10:20:11 -04:00
|
|
|
# @param regex [Regexp, nil] a regex used for matching versions
|
2021-08-10 18:38:21 -04:00
|
|
|
# @param provided_content [String, nil] page content to use in place of
|
2023-02-23 13:41:56 -05:00
|
|
|
# fetching via `Strategy#page_content`
|
2021-11-23 23:22:41 -05:00
|
|
|
# @param homebrew_curl [Boolean] whether to use brewed curl with the URL
|
2020-12-23 09:12:53 -05:00
|
|
|
# @return [Hash]
|
2021-01-17 22:45:55 -08:00
|
|
|
sig {
|
2020-12-23 09:12:53 -05:00
|
|
|
params(
|
|
|
|
url: String,
|
2021-08-19 10:20:11 -04:00
|
|
|
regex: T.nilable(Regexp),
|
2020-12-23 09:12:53 -05:00
|
|
|
provided_content: T.nilable(String),
|
2021-11-23 23:22:41 -05:00
|
|
|
homebrew_curl: T::Boolean,
|
2021-08-12 11:54:29 -04:00
|
|
|
_unused: T.nilable(T::Hash[Symbol, T.untyped]),
|
Handle variable strategy block arguments
There are times where a regex isn't needed in a `strategy` block and
these changes explicitly handle that situation.
This allows the Symbol Proc format used in some `Sparkle` `livecheck`
blocks (e.g., `strategy :sparkle, &:version`) to continue working
instead of failing with a "wrong number of arguments (given 1,
expected 0)" error. This error would occur because a Symbol Proc only
only expects one argument (e.g., an `Item`, not an `Item` and a
regex/nil).
There's an argument to be made for avoiding the Symbol Proc format
for `strategy` blocks but I haven't found a way of selectively
disabling the Style/SymbolProc cop only for a `strategy` DSL method
call. That is to say, if we don't use the Symbol Proc format, `brew
style` will give a "Pass &:version as an argument to strategy instead
of a block." offense.
Besides that, this also replaces the `block` type signatures in
livecheck strategies with `T.untyped`. Sorbet doesn't know how to
handle a `Proc` with a variable number of arguments and can't be
taught how (i.e., `T.any` with a `Proc` signature for each variation
doesn't work). The aforementioned changes cause Sorbet to complain
about there being both too many and too few arguments, so the only
way to win is not to play the game. Hopefully we can restore the
`block` type signatures in the future (if upstream resolves this
years-old issue) but `T.untyped` seems to be our only option for now.
2021-11-19 22:42:15 -05:00
|
|
|
block: T.untyped,
|
2020-12-23 09:12:53 -05:00
|
|
|
).returns(T::Hash[Symbol, T.untyped])
|
2021-01-17 22:45:55 -08:00
|
|
|
}
|
2021-11-23 23:22:41 -05:00
|
|
|
def self.find_versions(url:, regex: nil, provided_content: nil, homebrew_curl: false, **_unused, &block)
|
2021-11-19 23:37:29 -05:00
|
|
|
if regex.blank? && block.blank?
|
2023-02-27 20:16:34 -08:00
|
|
|
raise ArgumentError, "#{Utils.demodulize(T.must(name))} requires a regex or `strategy` block"
|
2021-11-19 23:37:29 -05:00
|
|
|
end
|
|
|
|
|
2020-08-08 07:16:06 +05:30
|
|
|
match_data = { matches: {}, regex: regex, url: url }
|
2021-08-19 09:01:11 -04:00
|
|
|
return match_data if url.blank? || (regex.blank? && block.blank?)
|
2020-08-08 07:16:06 +05:30
|
|
|
|
2020-12-24 21:49:30 -05:00
|
|
|
content = if provided_content.is_a?(String)
|
2020-12-24 22:19:14 -05:00
|
|
|
match_data[:cached] = true
|
2020-12-23 09:12:53 -05:00
|
|
|
provided_content
|
|
|
|
else
|
2021-11-23 23:22:41 -05:00
|
|
|
match_data.merge!(Strategy.page_content(url, homebrew_curl: homebrew_curl))
|
2020-12-24 21:48:31 -05:00
|
|
|
match_data[:content]
|
2020-12-23 09:12:53 -05:00
|
|
|
end
|
2020-12-22 22:46:52 -05:00
|
|
|
return match_data if content.blank?
|
|
|
|
|
2021-08-10 11:09:55 -04:00
|
|
|
versions_from_content(content, regex, &block).each do |match_text|
|
2020-12-22 22:46:52 -05:00
|
|
|
match_data[:matches][match_text] = Version.new(match_text)
|
2020-08-08 07:16:06 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
match_data
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|