2020-12-18 17:58:21 +01:00
|
|
|
# typed: true
|
2020-12-12 21:59:04 +01:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2020-12-13 12:23:20 +01:00
|
|
|
require "bundle_version"
|
2020-12-12 21:59:04 +01:00
|
|
|
|
|
|
|
module Homebrew
|
|
|
|
module Livecheck
|
|
|
|
module Strategy
|
2022-06-09 15:38:02 -04:00
|
|
|
# The {Sparkle} strategy fetches content at a URL and parses it as a
|
|
|
|
# Sparkle appcast in XML format.
|
2020-12-12 21:59:04 +01:00
|
|
|
#
|
2021-08-10 18:38:21 -04:00
|
|
|
# This strategy is not applied automatically and it's necessary to use
|
|
|
|
# `strategy :sparkle` in a `livecheck` block to apply it.
|
|
|
|
#
|
2020-12-12 21:59:04 +01:00
|
|
|
# @api private
|
2020-12-19 11:36:16 -05:00
|
|
|
class Sparkle
|
2020-12-12 21:59:04 +01:00
|
|
|
extend T::Sig
|
|
|
|
|
2021-08-10 18:38:21 -04:00
|
|
|
# A priority of zero causes livecheck to skip the strategy. We do this
|
|
|
|
# for {Sparkle} so we can selectively apply it when appropriate.
|
2020-12-19 11:36:16 -05:00
|
|
|
PRIORITY = 0
|
|
|
|
|
|
|
|
# The `Regexp` used to determine if the strategy applies to the URL.
|
|
|
|
URL_MATCH_REGEX = %r{^https?://}i.freeze
|
|
|
|
|
|
|
|
# Whether the strategy can be applied to the provided URL.
|
2021-08-10 18:38:21 -04:00
|
|
|
#
|
|
|
|
# @param url [String] the URL to match against
|
|
|
|
# @return [Boolean]
|
2020-12-19 11:36:16 -05:00
|
|
|
sig { params(url: String).returns(T::Boolean) }
|
|
|
|
def self.match?(url)
|
|
|
|
URL_MATCH_REGEX.match?(url)
|
|
|
|
end
|
|
|
|
|
2021-04-04 03:00:34 +02:00
|
|
|
# @api private
|
|
|
|
Item = Struct.new(
|
|
|
|
# @api public
|
|
|
|
:title,
|
2022-06-02 10:04:34 -04:00
|
|
|
# @api public
|
|
|
|
:channel,
|
2021-04-15 01:15:47 +02:00
|
|
|
# @api private
|
|
|
|
:pub_date,
|
2021-04-04 03:00:34 +02:00
|
|
|
# @api public
|
|
|
|
:url,
|
|
|
|
# @api private
|
|
|
|
:bundle_version,
|
|
|
|
keyword_init: true,
|
|
|
|
) do
|
2020-12-19 01:07:56 -05:00
|
|
|
extend T::Sig
|
2020-12-15 20:26:19 +01:00
|
|
|
|
2020-12-19 01:07:56 -05:00
|
|
|
extend Forwardable
|
2020-12-15 20:26:19 +01:00
|
|
|
|
2021-04-04 03:00:34 +02:00
|
|
|
# @api public
|
2020-12-19 01:07:56 -05:00
|
|
|
delegate version: :bundle_version
|
2021-04-04 03:00:34 +02:00
|
|
|
|
|
|
|
# @api public
|
2020-12-19 01:07:56 -05:00
|
|
|
delegate short_version: :bundle_version
|
2022-05-31 13:18:40 -04:00
|
|
|
|
|
|
|
# @api public
|
|
|
|
delegate nice_version: :bundle_version
|
2020-12-15 20:26:19 +01:00
|
|
|
end
|
|
|
|
|
2022-06-09 15:38:02 -04:00
|
|
|
# Identifies version information from a Sparkle appcast.
|
2021-08-10 18:38:21 -04:00
|
|
|
#
|
|
|
|
# @param content [String] the text of the Sparkle appcast
|
|
|
|
# @return [Item, nil]
|
2022-05-31 13:18:40 -04:00
|
|
|
sig { params(content: String).returns(T::Array[Item]) }
|
|
|
|
def self.items_from_content(content)
|
2023-02-27 17:03:32 -05:00
|
|
|
xml = Xml.parse_xml(content)
|
|
|
|
return [] if xml.blank?
|
2021-06-23 09:27:14 -04:00
|
|
|
|
|
|
|
# Remove prefixes, so we can reliably identify elements and attributes
|
|
|
|
xml.root&.each_recursive do |node|
|
|
|
|
node.prefix = ""
|
|
|
|
node.attributes.each_attribute do |attribute|
|
|
|
|
attribute.prefix = ""
|
|
|
|
end
|
|
|
|
end
|
2020-12-12 21:59:04 +01:00
|
|
|
|
2022-05-31 13:18:40 -04:00
|
|
|
xml.get_elements("//rss//channel//item").map do |item|
|
2021-06-23 09:27:14 -04:00
|
|
|
enclosure = item.elements["enclosure"]
|
2020-12-12 21:59:04 +01:00
|
|
|
|
2021-06-23 09:27:14 -04:00
|
|
|
if enclosure
|
|
|
|
url = enclosure["url"]
|
|
|
|
short_version = enclosure["shortVersionString"]
|
|
|
|
version = enclosure["version"]
|
|
|
|
os = enclosure["os"]
|
|
|
|
end
|
2020-12-14 05:04:14 +01:00
|
|
|
|
2022-06-02 10:04:34 -04:00
|
|
|
channel = item.elements["channel"]&.text
|
2021-06-23 09:27:14 -04:00
|
|
|
url ||= item.elements["link"]&.text
|
|
|
|
short_version ||= item.elements["shortVersionString"]&.text&.strip
|
|
|
|
version ||= item.elements["version"]&.text&.strip
|
2020-12-14 05:04:14 +01:00
|
|
|
|
2021-06-23 09:27:14 -04:00
|
|
|
title = item.elements["title"]&.text&.strip
|
2022-04-23 01:47:37 +01:00
|
|
|
pub_date = item.elements["pubDate"]&.text&.strip&.presence&.then do |date_string|
|
2021-06-22 09:55:22 -04:00
|
|
|
Time.parse(date_string)
|
|
|
|
rescue ArgumentError
|
|
|
|
# Omit unparseable strings (e.g. non-English dates)
|
|
|
|
nil
|
|
|
|
end
|
2020-12-14 11:34:27 +01:00
|
|
|
|
2021-02-12 18:33:37 +05:30
|
|
|
if (match = title&.match(/(\d+(?:\.\d+)*)\s*(\([^)]+\))?\Z/))
|
2020-12-14 11:34:27 +01:00
|
|
|
short_version ||= match[1]
|
|
|
|
version ||= match[2]
|
|
|
|
end
|
2020-12-14 05:04:14 +01:00
|
|
|
|
2020-12-18 21:17:55 +01:00
|
|
|
bundle_version = BundleVersion.new(short_version, version) if short_version || version
|
|
|
|
|
2022-10-22 12:25:53 -04:00
|
|
|
next if os && !((os == "osx") || (os == "macos"))
|
2021-01-09 04:46:22 +01:00
|
|
|
|
2021-06-28 15:48:35 -04:00
|
|
|
if (minimum_system_version = item.elements["minimumSystemVersion"]&.text&.gsub(/\A\D+|\D+\z/, ""))
|
2021-06-17 16:30:52 -07:00
|
|
|
macos_minimum_system_version = begin
|
2021-06-28 15:49:40 -04:00
|
|
|
OS::Mac::Version.new(minimum_system_version).strip_patch
|
2021-06-17 16:30:52 -07:00
|
|
|
rescue MacOSVersionError
|
|
|
|
nil
|
|
|
|
end
|
|
|
|
|
2021-06-28 15:49:40 -04:00
|
|
|
next if macos_minimum_system_version&.prerelease?
|
2021-06-17 16:30:52 -07:00
|
|
|
end
|
|
|
|
|
2020-12-14 05:41:41 +01:00
|
|
|
data = {
|
2020-12-14 11:34:27 +01:00
|
|
|
title: title,
|
2022-06-02 10:04:34 -04:00
|
|
|
channel: channel,
|
2022-05-31 13:18:40 -04:00
|
|
|
pub_date: pub_date,
|
2020-12-14 11:34:27 +01:00
|
|
|
url: url,
|
2020-12-18 21:17:55 +01:00
|
|
|
bundle_version: bundle_version,
|
2020-12-14 05:41:41 +01:00
|
|
|
}.compact
|
2022-05-31 13:18:40 -04:00
|
|
|
next if data.empty?
|
2020-12-14 05:41:41 +01:00
|
|
|
|
2022-05-31 13:18:40 -04:00
|
|
|
# Set a default `pub_date` (for sorting) if one isn't provided
|
|
|
|
data[:pub_date] ||= Time.new(0)
|
2020-12-14 05:04:14 +01:00
|
|
|
|
2022-05-31 13:18:40 -04:00
|
|
|
Item.new(**data)
|
|
|
|
end.compact
|
2020-12-15 20:26:19 +01:00
|
|
|
end
|
2020-12-14 05:04:14 +01:00
|
|
|
|
2022-06-09 15:38:02 -04:00
|
|
|
# Uses `#items_from_content` to identify versions from the Sparkle
|
|
|
|
# appcast content or, if a block is provided, passes the content to
|
|
|
|
# the block to handle matching.
|
2021-08-10 11:09:55 -04:00
|
|
|
#
|
2022-06-09 15:38:02 -04:00
|
|
|
# @param content [String] the content to check
|
|
|
|
# @param regex [Regexp, nil] a regex for use in a strategy block
|
2021-08-10 11:09:55 -04:00
|
|
|
# @return [Array]
|
|
|
|
sig {
|
|
|
|
params(
|
|
|
|
content: String,
|
2021-11-16 12:31:54 -05:00
|
|
|
regex: T.nilable(Regexp),
|
Handle variable strategy block arguments
There are times where a regex isn't needed in a `strategy` block and
these changes explicitly handle that situation.
This allows the Symbol Proc format used in some `Sparkle` `livecheck`
blocks (e.g., `strategy :sparkle, &:version`) to continue working
instead of failing with a "wrong number of arguments (given 1,
expected 0)" error. This error would occur because a Symbol Proc only
only expects one argument (e.g., an `Item`, not an `Item` and a
regex/nil).
There's an argument to be made for avoiding the Symbol Proc format
for `strategy` blocks but I haven't found a way of selectively
disabling the Style/SymbolProc cop only for a `strategy` DSL method
call. That is to say, if we don't use the Symbol Proc format, `brew
style` will give a "Pass &:version as an argument to strategy instead
of a block." offense.
Besides that, this also replaces the `block` type signatures in
livecheck strategies with `T.untyped`. Sorbet doesn't know how to
handle a `Proc` with a variable number of arguments and can't be
taught how (i.e., `T.any` with a `Proc` signature for each variation
doesn't work). The aforementioned changes cause Sorbet to complain
about there being both too many and too few arguments, so the only
way to win is not to play the game. Hopefully we can restore the
`block` type signatures in the future (if upstream resolves this
years-old issue) but `T.untyped` seems to be our only option for now.
2021-11-19 22:42:15 -05:00
|
|
|
block: T.untyped,
|
2021-08-10 11:09:55 -04:00
|
|
|
).returns(T::Array[String])
|
|
|
|
}
|
2021-11-16 12:31:54 -05:00
|
|
|
def self.versions_from_content(content, regex = nil, &block)
|
2022-05-31 13:18:40 -04:00
|
|
|
items = items_from_content(content).sort_by { |item| [item.pub_date, item.bundle_version] }.reverse
|
|
|
|
return [] if items.blank?
|
|
|
|
|
|
|
|
item = items.first
|
2021-08-10 11:09:55 -04:00
|
|
|
|
Handle variable strategy block arguments
There are times where a regex isn't needed in a `strategy` block and
these changes explicitly handle that situation.
This allows the Symbol Proc format used in some `Sparkle` `livecheck`
blocks (e.g., `strategy :sparkle, &:version`) to continue working
instead of failing with a "wrong number of arguments (given 1,
expected 0)" error. This error would occur because a Symbol Proc only
only expects one argument (e.g., an `Item`, not an `Item` and a
regex/nil).
There's an argument to be made for avoiding the Symbol Proc format
for `strategy` blocks but I haven't found a way of selectively
disabling the Style/SymbolProc cop only for a `strategy` DSL method
call. That is to say, if we don't use the Symbol Proc format, `brew
style` will give a "Pass &:version as an argument to strategy instead
of a block." offense.
Besides that, this also replaces the `block` type signatures in
livecheck strategies with `T.untyped`. Sorbet doesn't know how to
handle a `Proc` with a variable number of arguments and can't be
taught how (i.e., `T.any` with a `Proc` signature for each variation
doesn't work). The aforementioned changes cause Sorbet to complain
about there being both too many and too few arguments, so the only
way to win is not to play the game. Hopefully we can restore the
`block` type signatures in the future (if upstream resolves this
years-old issue) but `T.untyped` seems to be our only option for now.
2021-11-19 22:42:15 -05:00
|
|
|
if block
|
2022-05-31 13:18:40 -04:00
|
|
|
block_return_value = case block.parameters[0]
|
2022-10-18 01:32:55 +01:00
|
|
|
when [:opt, :item], [:rest], [:req]
|
2022-05-31 13:18:40 -04:00
|
|
|
regex.present? ? yield(item, regex) : yield(item)
|
|
|
|
when [:opt, :items]
|
|
|
|
regex.present? ? yield(items, regex) : yield(items)
|
|
|
|
else
|
|
|
|
raise "First argument of Sparkle `strategy` block must be `item` or `items`"
|
|
|
|
end
|
Handle variable strategy block arguments
There are times where a regex isn't needed in a `strategy` block and
these changes explicitly handle that situation.
This allows the Symbol Proc format used in some `Sparkle` `livecheck`
blocks (e.g., `strategy :sparkle, &:version`) to continue working
instead of failing with a "wrong number of arguments (given 1,
expected 0)" error. This error would occur because a Symbol Proc only
only expects one argument (e.g., an `Item`, not an `Item` and a
regex/nil).
There's an argument to be made for avoiding the Symbol Proc format
for `strategy` blocks but I haven't found a way of selectively
disabling the Style/SymbolProc cop only for a `strategy` DSL method
call. That is to say, if we don't use the Symbol Proc format, `brew
style` will give a "Pass &:version as an argument to strategy instead
of a block." offense.
Besides that, this also replaces the `block` type signatures in
livecheck strategies with `T.untyped`. Sorbet doesn't know how to
handle a `Proc` with a variable number of arguments and can't be
taught how (i.e., `T.any` with a `Proc` signature for each variation
doesn't work). The aforementioned changes cause Sorbet to complain
about there being both too many and too few arguments, so the only
way to win is not to play the game. Hopefully we can restore the
`block` type signatures in the future (if upstream resolves this
years-old issue) but `T.untyped` seems to be our only option for now.
2021-11-19 22:42:15 -05:00
|
|
|
return Strategy.handle_block_return(block_return_value)
|
|
|
|
end
|
2021-08-10 11:09:55 -04:00
|
|
|
|
2022-05-31 13:18:40 -04:00
|
|
|
version = T.must(item).bundle_version&.nice_version
|
2021-08-10 11:09:55 -04:00
|
|
|
version.present? ? [version] : []
|
|
|
|
end
|
|
|
|
|
2020-12-19 01:07:56 -05:00
|
|
|
# Checks the content at the URL for new versions.
|
2022-06-09 15:38:02 -04:00
|
|
|
#
|
|
|
|
# @param url [String] the URL of the content to check
|
|
|
|
# @param regex [Regexp, nil] a regex for use in a strategy block
|
|
|
|
# @return [Hash]
|
2021-04-04 03:00:34 +02:00
|
|
|
sig {
|
|
|
|
params(
|
2021-11-16 12:31:54 -05:00
|
|
|
url: String,
|
|
|
|
regex: T.nilable(Regexp),
|
|
|
|
_unused: T.nilable(T::Hash[Symbol, T.untyped]),
|
Handle variable strategy block arguments
There are times where a regex isn't needed in a `strategy` block and
these changes explicitly handle that situation.
This allows the Symbol Proc format used in some `Sparkle` `livecheck`
blocks (e.g., `strategy :sparkle, &:version`) to continue working
instead of failing with a "wrong number of arguments (given 1,
expected 0)" error. This error would occur because a Symbol Proc only
only expects one argument (e.g., an `Item`, not an `Item` and a
regex/nil).
There's an argument to be made for avoiding the Symbol Proc format
for `strategy` blocks but I haven't found a way of selectively
disabling the Style/SymbolProc cop only for a `strategy` DSL method
call. That is to say, if we don't use the Symbol Proc format, `brew
style` will give a "Pass &:version as an argument to strategy instead
of a block." offense.
Besides that, this also replaces the `block` type signatures in
livecheck strategies with `T.untyped`. Sorbet doesn't know how to
handle a `Proc` with a variable number of arguments and can't be
taught how (i.e., `T.any` with a `Proc` signature for each variation
doesn't work). The aforementioned changes cause Sorbet to complain
about there being both too many and too few arguments, so the only
way to win is not to play the game. Hopefully we can restore the
`block` type signatures in the future (if upstream resolves this
years-old issue) but `T.untyped` seems to be our only option for now.
2021-11-19 22:42:15 -05:00
|
|
|
block: T.untyped,
|
2021-04-04 03:00:34 +02:00
|
|
|
).returns(T::Hash[Symbol, T.untyped])
|
|
|
|
}
|
2021-11-16 12:31:54 -05:00
|
|
|
def self.find_versions(url:, regex: nil, **_unused, &block)
|
|
|
|
if regex.present? && block.blank?
|
2023-02-23 12:23:44 -08:00
|
|
|
raise ArgumentError,
|
2023-02-27 20:16:34 -08:00
|
|
|
"#{Utils.demodulize(T.must(name))} only supports a regex when using a `strategy` block"
|
2021-11-16 12:31:54 -05:00
|
|
|
end
|
2020-12-13 12:23:20 +01:00
|
|
|
|
2022-06-09 15:33:42 -04:00
|
|
|
match_data = { matches: {}, regex: regex, url: url }
|
2020-12-12 21:59:04 +01:00
|
|
|
|
2020-12-24 03:33:14 +01:00
|
|
|
match_data.merge!(Strategy.page_content(url))
|
|
|
|
content = match_data.delete(:content)
|
2020-12-19 01:07:56 -05:00
|
|
|
|
2021-11-16 12:31:54 -05:00
|
|
|
versions_from_content(content, regex, &block).each do |version_text|
|
2021-08-10 11:09:55 -04:00
|
|
|
match_data[:matches][version_text] = Version.new(version_text)
|
2020-12-19 01:07:56 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
match_data
|
2020-12-12 21:59:04 +01:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|