102 lines
3.3 KiB
Ruby
Raw Normal View History

2024-03-21 21:44:06 -07:00
# typed: strict
# frozen_string_literal: true
2024-03-21 21:44:06 -07:00
require "abstract_command"
require "json"
2017-05-29 01:21:36 +02:00
require "open3"
require "style"
module Homebrew
2024-03-21 21:44:06 -07:00
module DevCmd
class StyleCmd < AbstractCommand
cmd_args do
description <<~EOS
Check formulae or files for conformance to Homebrew style guidelines.
2016-09-26 01:44:51 +02:00
2024-03-21 21:44:06 -07:00
Lists of <file>, <tap> and <formula> may not be combined. If none are
provided, `style` will run style checks on the whole Homebrew library,
including core code and all formulae.
EOS
switch "--fix",
description: "Fix style violations automatically using RuboCop's auto-correct feature."
switch "--display-cop-names",
description: "Include the RuboCop cop name for each violation in the output.",
hidden: true
switch "--reset-cache",
description: "Reset the RuboCop cache."
switch "--changed",
description: "Check files that were changed from the `main` branch."
2024-03-21 21:44:06 -07:00
switch "--formula", "--formulae",
description: "Treat all named arguments as formulae."
switch "--cask", "--casks",
description: "Treat all named arguments as casks."
comma_array "--only-cops",
description: "Specify a comma-separated <cops> list to check for violations of only the " \
"listed RuboCop cops."
comma_array "--except-cops",
description: "Specify a comma-separated <cops> list to skip checking for violations of the " \
"listed RuboCop cops."
2018-11-07 23:44:34 +05:30
2024-03-21 21:44:06 -07:00
conflicts "--formula", "--cask"
conflicts "--only-cops", "--except-cops"
2020-07-30 18:40:10 +02:00
2024-03-21 21:44:06 -07:00
named_args [:file, :tap, :formula, :cask], without_api: true
end
2021-01-10 14:26:40 -05:00
2024-03-21 21:44:06 -07:00
sig { override.void }
def run
Homebrew.install_bundler_gems!(groups: ["style"])
if args.changed? && !args.no_named?
raise UsageError, "`--changed` and named arguments are mutually exclusive!"
end
target = if args.changed?
changed_ruby_or_shell_files
elsif args.no_named?
2024-03-21 21:44:06 -07:00
nil
else
args.named.to_paths
end
2018-11-07 23:44:34 +05:30
if target.blank? && args.changed?
opoo "No style checks are available for the changed files!"
return
end
2024-03-21 21:44:06 -07:00
only_cops = args.only_cops
except_cops = args.except_cops
2018-11-07 23:44:34 +05:30
2024-03-21 21:44:06 -07:00
options = {
fix: args.fix?,
reset_cache: args.reset_cache?,
debug: args.debug?,
verbose: args.verbose?,
}
if only_cops
options[:only_cops] = only_cops
elsif except_cops
options[:except_cops] = except_cops
else
options[:except_cops] = %w[FormulaAuditStrict]
end
2024-03-21 21:44:06 -07:00
Homebrew.failed = !Style.check_style_and_print(target, **options)
end
sig { returns(T::Array[String]) }
def changed_ruby_or_shell_files
changed_files = Utils.popen_read("git", "diff", "--name-only", "main")
raise UsageError, "No files have been changed from the `main` branch!" if changed_files.blank?
changed_files.split("\n").filter_map do |file|
next if !file.end_with?(".rb", ".sh", ".yml", ".rbi") && file != "bin/brew"
Pathname(file)
end.select(&:exist?)
end
end
end
end