2021-01-31 14:50:29 -05:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require "rubocops/livecheck"
|
|
|
|
|
2024-02-18 15:11:11 -08:00
|
|
|
RSpec.describe RuboCop::Cop::FormulaAudit::LivecheckUrlProvided do
|
2021-01-31 14:50:29 -05:00
|
|
|
subject(:cop) { described_class.new }
|
|
|
|
|
2024-12-02 10:06:14 -05:00
|
|
|
it "reports an offense when a `url` is not specified in a `livecheck` block" do
|
2021-01-31 14:50:29 -05:00
|
|
|
expect_offense(<<~RUBY)
|
|
|
|
class Foo < Formula
|
|
|
|
url "https://brew.sh/foo-1.0.tgz"
|
|
|
|
|
|
|
|
livecheck do
|
2024-03-21 15:34:13 -04:00
|
|
|
^^^^^^^^^^^^ FormulaAudit/LivecheckUrlProvided: A `url` should be provided when `regex` or `strategy` are used.
|
2021-01-31 14:50:29 -05:00
|
|
|
regex(%r{href=.*?/formula[._-]v?(\\d+(?:\\.\\d+)+)\\.t}i)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
RUBY
|
2024-03-21 15:34:13 -04:00
|
|
|
|
|
|
|
expect_offense(<<~RUBY)
|
|
|
|
class Foo < Formula
|
|
|
|
url "https://brew.sh/foo-1.0.tgz"
|
|
|
|
|
|
|
|
livecheck do
|
|
|
|
^^^^^^^^^^^^ FormulaAudit/LivecheckUrlProvided: A `url` should be provided when `regex` or `strategy` are used.
|
|
|
|
strategy :page_match
|
|
|
|
end
|
|
|
|
end
|
|
|
|
RUBY
|
2021-01-31 14:50:29 -05:00
|
|
|
end
|
|
|
|
|
2024-12-02 10:06:14 -05:00
|
|
|
it "reports no offenses when a `url` and `regex` are specified in the `livecheck` block" do
|
2021-01-31 14:50:29 -05:00
|
|
|
expect_no_offenses(<<~RUBY)
|
|
|
|
class Foo < Formula
|
|
|
|
url "https://brew.sh/foo-1.0.tgz"
|
|
|
|
|
|
|
|
livecheck do
|
|
|
|
url :stable
|
|
|
|
regex(%r{href=.*?/formula[._-]v?(\\d+(?:\\.\\d+)+)\\.t}i)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
RUBY
|
|
|
|
end
|
2024-03-21 15:34:13 -04:00
|
|
|
|
2024-12-02 10:06:14 -05:00
|
|
|
it "reports no offenses when a `url` and `strategy` are specified in the `livecheck` block" do
|
2024-03-21 15:34:13 -04:00
|
|
|
expect_no_offenses(<<~RUBY)
|
|
|
|
class Foo < Formula
|
|
|
|
url "https://brew.sh/foo-1.0.tgz"
|
|
|
|
|
|
|
|
livecheck do
|
|
|
|
url :stable
|
|
|
|
strategy :page_match
|
|
|
|
end
|
|
|
|
end
|
|
|
|
RUBY
|
|
|
|
end
|
2021-01-31 14:50:29 -05:00
|
|
|
end
|